docs: add note about new executable name in migration guide#2403
Merged
jackwotherspoon merged 2 commits intoGoogleCloudPlatform:mainfrom Mar 10, 2025
Merged
docs: add note about new executable name in migration guide#2403jackwotherspoon merged 2 commits intoGoogleCloudPlatform:mainfrom
jackwotherspoon merged 2 commits intoGoogleCloudPlatform:mainfrom
Conversation
It is a subtle difference to notice in all the examples that the executable name has changed from using underscores to hyphens. It is helpful to the reader to have this explicitly pointed out, the same way that the other changes have been spelled out.
jackwotherspoon
requested changes
Mar 10, 2025
Collaborator
jackwotherspoon
left a comment
jackwotherspoon
left a comment
There was a problem hiding this comment.
Small nit, otherwise LGTM 👍
Thanks a ton for this @bseib 👏
Definitely worth explicitly calling out the name change.
jackwotherspoon
changed the title
jackwotherspoon
approved these changes
Mar 10, 2025
Collaborator
|
Thanks again @bseib 😄 If you have any other general feedback about the Proxy or our docs, please let me know! We definitely value feedback and will make sure to create docs/feature bugs for any enhancements or suggestions. |
Contributor
Author
|
Thanks for the quick review and merge @jackwotherspoon ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is a subtle difference to notice in all the examples that the executable name has changed from using underscores to hyphens. It would be helpful to the reader to have this explicitly pointed out, the same way that the other changes have been spelled out.
(Yes, it is obvious and self-evident when you are typing the old/new command on the command line that
cloud_sql_proxydoes not exist. But I lost a good bit time pinpointing this problem when it was inside a k8s container that had been converted from v1 to v2, even when I got all the new flag changes correct! 😀)